MONGOSH-278 - Notarize macOS package #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
force-pushed
the
macos-sign
branch
5 times, most recently
from
5b0dc59 to
a1e1d88
Compare
addaleax
changed the title
addaleax
force-pushed
the
macos-sign
branch
from
a1e1d88 to
9160946
Compare
addaleax
commented
Sep 25, 2020
addaleax
commented
Sep 25, 2020
| "mongodb-js-precommit": "^2.0.0", | ||
| "mongodb-runner": "^4.7.5", | ||
| "node-codesign": "durran/node-codesign", | ||
| "node-codesign": "github:addaleax/node-codesign", |
There was a problem hiding this comment.
This is just so that the entitlements option becomes available … this should probably become some official npm package at some point, I might ping Durran about it after this is merged :)
There was a problem hiding this comment.
yea i was looking at that before, and we should just publish it.
There was a problem hiding this comment.
Yeah, I’ll ping Durran and if nothing speaks against it I’ll move this into the org (i.e. move it back, but as node-codesign) and publish it :)
addaleax
force-pushed
the
macos-sign
branch
4 times, most recently
from
87bd474 to
5af0edc
Compare
addaleax
force-pushed
the
macos-sign
branch
from
5af0edc to
0c32a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.