Skip to content

Conversation

addaleax
Copy link
Collaborator

No description provided.

@addaleax addaleax added the wip Work in Progress label Oct 20, 2020
@addaleax addaleax force-pushed the 248-dev branch 2 times, most recently from d1e211b to d2f4f08 Compare October 21, 2020 11:09
@addaleax addaleax removed the wip Work in Progress label Oct 22, 2020
Copy link
Contributor

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @addaleax! Thanks for tackling this \o/

Copy link
Collaborator

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

"scripts": {
"browserify-shell-api": "browserify src/main/js/all.js -o src/main/resources/js/all-standalone.js -dv",
"test-ci": "npm run test"
"test": "mocha -r \"../../scripts/import-expansions.js\" --timeout 60000 --colors -r ts-node/register \"./src/test/js/run-tests.ts\"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do i need locally to run this? Should we add some docs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s the same as the other packages – it’s part of npm test on the root module. Whether that’s good or not is another question, it requires Java, but then again npm test already requires stuff like headless chrome, so … 🤷‍♀️

@addaleax addaleax merged commit 3927161 into master Oct 22, 2020
@addaleax addaleax deleted the 248-dev branch October 22, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants