fix: correctly format several values in browser-repl #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the formatting for several values in the browser REPL. Since fixing this for Date objects consistently enabled doing straightforward fixes for a few other issues, this addresses: - COMPASS-4440 (Consistently formatting `Date` objects) - COMPASS-4441 (Ignoring `undefined` results) - MONGOSH-410 (`sh.status()` formatting) - COMPASS-4465 (`ObjectId` formatting in nested objects)
mcasimir
reviewed
Nov 6, 2020
| import { CursorOutput } from './types/cursor-output'; | ||
| import { CursorIterationResultOutput } from './types/cursor-iteration-result-output'; | ||
| import { ObjectOutput } from './types/object-output'; | ||
| import { StatsResultOutput } from './types/stats-result-output'; |
There was a problem hiding this comment.
what should we do in future to avoid forgetting to implement these here?
There was a problem hiding this comment.
Well … we didn’t forget to implement this, we just didn’t check properly whether it works as intended in the browser repl, I think
I’m not really worried about this being a common occurrence, tbh
mcasimir
approved these changes
Nov 6, 2020
addaleax
added a commit
to mongodb-js/compass
that referenced
this pull request
Nov 11, 2020
Fixes several formatting issues through mongodb-js/mongosh#395: - COMPASS-4440 (Consistently formatting `Date` objects) - COMPASS-4441 (Ignoring `undefined` results) - MONGOSH-410 (`sh.status()` formatting) - COMPASS-4465 (`ObjectId` formatting in nested objects)
10 tasks
addaleax
added a commit
to mongodb-js/compass
that referenced
this pull request
Nov 12, 2020
Fixes several formatting issues through mongodb-js/mongosh#395: - COMPASS-4440 (Consistently formatting `Date` objects) - COMPASS-4441 (Ignoring `undefined` results) - MONGOSH-410 (`sh.status()` formatting) - COMPASS-4465 (`ObjectId` formatting in nested objects)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the formatting for several values in the browser REPL.
Since fixing this for Date objects consistently enabled doing
straightforward fixes for a few other issues, this addresses:
Dateobjects)undefinedresults)sh.status()formatting)ObjectIdformatting in nested objects)