fix(build): set NODE_JS_VERSION in Unix CI #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we just build with any newer Node.js 12.x version, unlike Windows. This bug led to the 0.5.1 release happening with Node.js 12.18.4 on Windows and Node.js 12.19.0 on other platforms. Let’s pick a consistent version. Pick 12.18.4 rather than 12.19.0 because we’re currently seeing Node.js deprecation warnings being shown with 12.19.0 (until mongodb-js/boxednode#9 is merged).
gribnoysup
approved these changes
Nov 11, 2020
rose-m
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we just build with any newer Node.js 12.x version,
unlike Windows.
This bug led to the 0.5.1 release happening with Node.js 12.18.4
on Windows and Node.js 12.19.0 on other platforms.
Let’s pick a consistent version. Pick 12.18.4 rather than 12.19.0
because we’re currently seeing Node.js deprecation warnings being
shown with 12.19.0 (until
mongodb-js/boxednode#9 is merged).