Skip to content

chore(test): do not fail tests if cleaning up fake homedir fails #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2020
Merged

chore(test): do not fail tests if cleaning up fake homedir fails #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/cli-repl/test/e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,13 @@ describe('e2e', function() {

afterEach(async() => {
await TestShell.killall();
await promisify(rimraf)(homedir);
try {
await promisify(rimraf)(homedir);
} catch (err) {
// On Windows in CI, this can fail with EPERM for some reason.
// If it does, just log the error instead of failing all tests.
console.error('Could not remove fake home directory:', err);
}
});

describe('config file', async() => {
Expand Down