feat(cli-repl): upgrade Node.js to v14.x MONGOSH-438

.evergreen/.install_node

@@ -1,5 +1,4 @@
 set -e
-export NODE_JS_VERSION='12.18.4'
 export NVM_DIR="$HOME/.nvm"
 
 curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash

.evergreen/.setup_env

@@ -1,5 +1,4 @@
 set -e
-export NODE_JS_VERSION='12.18.4'
 export NVM_DIR="$HOME/.nvm"
 echo "Setting NVM environment home: $NVM_DIR"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

.evergreen/InstallNode.ps1

@@ -1,4 +1,4 @@
-$version = "12.18.4"
+$version = "$Env:NODE_JS_VERSION"
 $url = "https://nodejs.org/download/release/v$version/node-v$version-win-x64.zip"
 $filename = "node.zip"
 $node_zip = "$PSScriptRoot\$filename"

.evergreen/SetupEnv.ps1

@@ -1,6 +1,5 @@
-$version = "12.18.4"
+$version = "$Env:NODE_JS_VERSION"
 $Env:PATH = "$PSScriptRoot\node-v$version-win-x64;C:\Python39\Scripts;C:\Python39;C:\Program Files\Git\mingw32\libexec\git-core;$Env:PATH"
-$Env:NODE_JS_VERSION = "$version"
 
 echo "Using node version:"
 node --version

CONTRIBUTING.md

@@ -18,3 +18,13 @@ MongoDB welcomes community contributions! If you’re interested in making a con
 You can report new bugs by
 [creating a new issue](https://jira.mongodb.org/browse/MONGOSH/).
 Please include as much information as possible about your environment.
+
+## Node.js versions
+
+We support Node.js 12.x+ for the individual packages, and Node.js 14.x only for
+the CLI repl specifically. These versions are mentioned:
+
+- In the individual packages’ package.json files
+- In the evergreen config
+- In the homebrew generation script
+- In the Docker files we use for building the binary/testing vscode

packages/cli-repl/package.json

@@ -32,7 +32,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=12.4.0"
+    "node": ">=14.15.0"
   },
   "dependencies": {
     "@mongosh/autocomplete": "^0.5.2",

packages/cli-repl/src/cli-repl.spec.ts

@@ -108,8 +108,11 @@ describe('CliRepl', () => {
       });
 
       it('verifies the Node.js version', async() => {
+        const origVersionCheckEnvVar = process.env.MONGOSH_SKIP_NODE_VERSION_CHECK;
+        delete process.env.MONGOSH_SKIP_NODE_VERSION_CHECK;
         delete (process as any).version;
         process.version = 'v8.0.0';
+
         try {
           cliRepl = new CliRepl(cliReplOptions);
           const onerror = once(cliRepl.bus, 'mongosh:error');
@@ -119,6 +122,7 @@ describe('CliRepl', () => {
           await onerror;
         } finally {
           process.version = process.versions.node;
+          process.env.MONGOSH_SKIP_NODE_VERSION_CHECK = origVersionCheckEnvVar || '';
         }
       });
     });

packages/cli-repl/src/cli-repl.ts

@@ -142,6 +142,9 @@ class CliRepl {
   }
 
   verifyNodeVersion(): void {
+    if (process.env.MONGOSH_SKIP_NODE_VERSION_CHECK) {
+      return;
+    }
     const { engines } = require('../package.json');
     // Strip -rc.0, -pre, etc. from the Node.js version because semver rejects those otherwise.
     const baseNodeVersion = process.version.replace(/-.*$/, '');

packages/mongosh/package.json

@@ -34,6 +34,6 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=12.4.0"
+    "node": ">=14.15.0"
   }
 }

scripts/docker/ubuntu16.04-build.Dockerfile

@@ -5,8 +5,8 @@ RUN apt-get -y -qq install build-essential python2.7 curl apt-transport-https ca
 
 # Add Node.js
 RUN curl -sSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -
-RUN echo "deb https://deb.nodesource.com/node_12.x xenial main" | tee /etc/apt/sources.list.d/nodesource.list
-RUN echo "deb-src https://deb.nodesource.com/node_12.x xenial main" | tee -a /etc/apt/sources.list.d/nodesource.list
+RUN echo "deb https://deb.nodesource.com/node_14.x xenial main" | tee /etc/apt/sources.list.d/nodesource.list
+RUN echo "deb-src https://deb.nodesource.com/node_14.x xenial main" | tee -a /etc/apt/sources.list.d/nodesource.list
 
 # Add sufficiently recent compiler toolchain
 RUN add-apt-repository ppa:ubuntu-toolchain-r/test

scripts/generate-homebrew-formula.js

@@ -31,11 +31,11 @@ class Mongosh < Formula
   # curl -s https://registry.npmjs.org/@mongosh/cli-repl/-/cli-repl-${context.version}.tgz | shasum -a 256
   sha256 "${context.sha}"
 
-  depends_on "node@12"
+  depends_on "node@14"
 
   def install
-    system "#{Formula["node@12"].bin}/npm", "install", *Language::Node.std_npm_install_args(libexec)
-    (bin/"mongosh").write_env_script libexec/"bin/mongosh", :PATH => "#{Formula["node@12"].opt_bin}:$PATH"
+    system "#{Formula["node@14"].bin}/npm", "install", *Language::Node.std_npm_install_args(libexec)
+    (bin/"mongosh").write_env_script libexec/"bin/mongosh", :PATH => "#{Formula["node@14"].opt_bin}:$PATH"
   end
 
   test do
@@ -96,4 +96,4 @@ if (require.main === module) {
   );
 } else {
   module.exports = generateHomebrewFormula;
-}
+}