Skip to content

chore(cli-repl): use separate tmpdir for userId persistence test #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2020
Merged

chore(cli-repl): use separate tmpdir for userId persistence test #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/cli-repl/src/cli-repl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import { PassThrough, Duplex } from 'stream';
import { promisify } from 'util';
import path from 'path';
import { promises as fs } from 'fs';
import { once } from 'events';
import rimraf from 'rimraf';
import CliRepl, { CliReplOptions } from './cli-repl';
import { startTestServer } from '../../../testing/integration-testing-hooks';
import { expect, useTmpdir, waitEval, fakeTTYProps } from '../test/repl-helpers';
Expand Down Expand Up @@ -75,7 +73,6 @@ describe('CliRepl', () => {
context('during startup', () => {
it('persists userId', async() => {
const userIds: string[] = [];
await promisify(rimraf)(tmpdir.path);
for (let i = 0; i < 2; i++) {
cliRepl = new CliRepl(cliReplOptions);
cliRepl.bus.on('mongosh:new-user', userId => userIds.push(userId));
Expand Down
8 changes: 7 additions & 1 deletion packages/cli-repl/test/repl-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ function useTmpdir(): { readonly path: string } {
});

afterEach(async() => {
promisify(rimraf)(tmpdir);
try {
await promisify(rimraf)(tmpdir);
} catch (err) {
// On Windows in CI, this can fail with EPERM for some reason.
// If it does, just log the error instead of failing all tests.
console.error('Could not remove fake home directory:', err);
}
});

return {
Expand Down