chore(build): streamline release command execution MONGOSH-534 #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
force-pushed
the
MONGOSH-534-streamline-release-command-execution
branch
from
6c4cdf7 to
4c0b7ac
Compare
rose-m
force-pushed
the
MONGOSH-534-streamline-release-command-execution
branch
from
4c0b7ac to
b197b8b
Compare
addaleax
reviewed
Feb 12, 2021
addaleax
approved these changes
Feb 12, 2021
rose-m
force-pushed
the
MONGOSH-534-streamline-release-command-execution
branch
from
1e1bae2 to
0f9d889
Compare
addaleax
reviewed
Feb 15, 2021
| export NODE_JS_VERSION=${NODE_JS_VERSION} | ||
| export ARTIFACT_URL_FILE=artifact-url.txt | ||
| export ARTIFACT_URL_FILE="$PWD/artifact-url.txt" |
There was a problem hiding this comment.
If you want to use absolute paths on Windows, you’ll need to use cygpath -w on the filepath before passing it to Node.js (because this would be /cygdrive/c/.../artifact-url.txt, which on Windows would be interpreted as a path relative to the FS root, e.g. C:\cygdrive\c\...\artifact-url.txt)
There was a problem hiding this comment.
I hope the way I've included it now makes that part work...
addaleax
approved these changes
Feb 15, 2021
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ts-nodeto directly run the entry script inbuild/src/index.ts.