fix(service-provider-server): accept functions in createView MONGOSH-585 #655
Conversation
| }); | ||
| it('creates a view that potentially contains JS functions in its pipeline', async() => { | ||
| const pipeline = (body: any) => [{ | ||
| '$set': { |
There was a problem hiding this comment.
I see that tests are failing, maybe this should be addFields instead? (Big disclaimer: I'm not really good with aggregations so not sure if what I'm suggesting matches what you wanted to achieve with the pipeline 😅)
| '$set': { | |
| '$addFields': { |
There was a problem hiding this comment.
Oh, I’m also fairly clueless here. This passed locally and was taken directly from the ticket, and it looks like it’s the cli-service-provider tests that are failing (because I didn’t run them locally, which is entirely my fault, but … 🤷)
There was a problem hiding this comment.
Did some googling around and seems like $set is a new feature in 4.2 and $function is new in 4.4. Should we skip that test for anything that is less than that?
There was a problem hiding this comment.
just pushed a commit for that, yes :)
There was a problem hiding this comment.
Haha, ~ at the same time, perfect timing 😄
2 participants
No description provided.