Skip to content

fix(cli-repl): show telemetry info only once MONGOSH-582 #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2021
Merged

fix(cli-repl): show telemetry info only once MONGOSH-582 #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db7e94d
fix(cli-repl): show telemetry info only once MONGOSH-582
addaleax Feb 12, 2021
7bb8daa
fixup
addaleax Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/cli-repl/src/cli-repl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ class CliRepl {
async setConfig<K extends keyof UserConfig>(key: K, value: UserConfig[K]): Promise<void> {
this.config[key] = value;
if (key === 'enableTelemetry') {
this.config.disableGreetingMessage = true;
this.bus.emit('mongosh:update-user', this.config.userId, this.config.enableTelemetry);
}
try {
Expand Down
1 change: 1 addition & 0 deletions packages/cli-repl/src/mongosh-repl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ describe('MongoshNodeRepl', () => {
expect(output).to.match(/Using MongoDB:\s+4.4.1/);
expect(output).to.match(/Using Mongosh Beta:/);
expect(output).to.match(/You can opt-out by running the .*disableTelemetry\(\).* command/);
expect(config.disableGreetingMessage).to.equal(true);
});

it('evaluates javascript', async() => {
Expand Down
1 change: 1 addition & 0 deletions packages/cli-repl/src/mongosh-repl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ class MongoshNodeRepl implements EvaluationListener {
text += `${MONGOSH_WIKI}\n`;
if (!await this.configProvider.getConfig('disableGreetingMessage')) {
text += `${TELEMETRY_GREETING_MESSAGE}\n`;
await this.configProvider.setConfig('disableGreetingMessage', true);
}
this.output.write(text);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-repl/test/e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ describe('e2e', function() {
const config = await readConfig();
expect(config.userId).to.match(/^[a-f0-9]{24}$/);
expect(config.enableTelemetry).to.be.true;
expect(config.disableGreetingMessage).to.be.false;
expect(config.disableGreetingMessage).to.be.true;
});

it('persists between sessions', async() => {
Expand Down