fix(cli-repl): disregard autocomplete eval for input stream MONGOSH-586 #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the second half of MONGOSH-586. The REPL’s built-in autocompleter uses `repl.eval()` to figure out what JS object’s properties it would be autocompleting. These `.eval()` calls don’t represent a state change as far as input handling is concerned, so they should not affect the prompt and not enable block-on-newline.
gribnoysup
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second half of MONGOSH-586.
The REPL’s built-in autocompleter uses
repl.eval()to figure outwhat JS object’s properties it would be autocompleting. These
.eval()calls don’t represent a state change as far as inputhandling is concerned, so they should not affect the prompt and not
enable block-on-newline.