chore(build): add local release command MONGOSH-530 #667
Conversation
| return new Promise((resolve, reject) => { | ||
| try { | ||
| const rl = readline.createInterface({ | ||
| input: process.stdin, | ||
| output: process.stdout | ||
| }); | ||
|
|
||
| rl.question(`${prompt} `, (answer) => { | ||
| rl.close(); | ||
| resolve(answer); | ||
| }); | ||
| } catch (e) { | ||
| reject(e); | ||
| } | ||
| }); |
There was a problem hiding this comment.
| return new Promise((resolve, reject) => { | |
| try { | |
| const rl = readline.createInterface({ | |
| input: process.stdin, | |
| output: process.stdout | |
| }); | |
| rl.question(`${prompt} `, (answer) => { | |
| rl.close(); | |
| resolve(answer); | |
| }); | |
| } catch (e) { | |
| reject(e); | |
| } | |
| }); | |
| return new Promise(resolve => { | |
| const rl = readline.createInterface({ | |
| input: process.stdin, | |
| output: process.stdout | |
| }); | |
| rl.question(`${prompt} `, (answer) => { | |
| rl.close(); | |
| resolve(answer); | |
| }); | |
| }); |
(Exceptions from inside the Promise constructor’s callback are turned into rejections automatically :))
There was a problem hiding this comment.
Huh, that makes sense :D
| }).filter(t => !!t) as TagDetails[]; | ||
|
|
||
| return { commit, tags: tagDetails }; | ||
| } |
There was a problem hiding this comment.
Would we maybe better start out with git tag, looking for the tag that we actually care about, and then use git log -n1 --pretty='%H' <tag> to get the commit hash?
There was a problem hiding this comment.
Yeah sounds good to me, too. Probably the main difference is that git tag gives us all tags in the repo we already know whereas the git log check returns only those from the current branch.
How is that in the case of future support releases? 🤔 <- That question I'd rather answer in a different ticket.
So changing to git tag and grabbing hash afterwards for now!
| } | ||
| if (!repositoryStatus.branch.tracking) { | ||
| throw new Error('The branch you are on is not tracking any remote branch. Ensure you are on the master branch of the repository.'); | ||
| } |
There was a problem hiding this comment.
These things are actually moving us further away from being able to do support releases, right? Could we maybe prompt the user instead to make sure they’re on the right branch?
There was a problem hiding this comment.
Yeah it depends probably on how we want to do them. At least a tracking branch should be there. Right now I've put in the master guard just for good measure. I'd assume we create a separate branch for a support release and tag on that branch. But for that it should definitely be pushed to the remote (thus we should have a tracking branch).
There was a problem hiding this comment.
Yeah, I wasn’t referring to the tracking branch check specifically, sorry :) Maybe we could do some very crude regex check here, e.g. /^master$|^main$|^v\d+\.\d+\.\d+/ (main because of https://jira.mongodb.org/browse/MONGOSH-245)?
There was a problem hiding this comment.
That's a good idea 👍 So we'd cover master/main and potential support release branches (which would equal to the designated version number)... ✅
There was a problem hiding this comment.
Hm yeah … and maybe also allow [xyz0-9] instead of \d, I don’t think we have any idea what the branch naming scheme will look like but using things like v0.x.y or v0.8.x would be common
| cwd: repositoryRoot, | ||
| encoding: 'utf-8' | ||
| }); | ||
| spawnSync('git', ['push', '--tags'], { |
There was a problem hiding this comment.
I would maybe recommend only pushing the tag that we created here, instead of any tags the user might have lying around as well
There was a problem hiding this comment.
I currently fail if the user has unpushed tags - so here it would not push anything additional. But good point, might change that to only push that specific tag.
2 participants
No description provided.