Skip to content

chore(build): simplify analytics config generation #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

chore(build): simplify analytics config generation #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/build/src/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import util from 'util';
import fs from 'fs';
import handlebars from 'handlebars';

/**
* The template.
*/
const TEMPLATE = 'module.exports = { SEGMENT_API_KEY: "{{segmentKey}}" };';

/**
* Create the analytics config.
Expand All @@ -15,8 +9,7 @@ const TEMPLATE = 'module.exports = { SEGMENT_API_KEY: "{{segmentKey}}" };';
* @returns {string} The compiled template.
*/
export function createAnalyticsConfig(segmentKey: string): string {
const template = handlebars.compile(TEMPLATE);
return template({ segmentKey: segmentKey });
return `module.exports = { SEGMENT_API_KEY: ${JSON.stringify(segmentKey)} };`;
}

/**
Expand Down