Skip to content

fix(node-runtime-worker-thread): Read worker source and eval instead of passing path to the worker constructor MONGOSH-613 #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021
Merged

fix(node-runtime-worker-thread): Read worker source and eval instead of passing path to the worker constructor MONGOSH-613 #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/node-runtime-worker-thread/src/child-process-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,20 @@
*/
import { once } from 'events';
import { SHARE_ENV, Worker } from 'worker_threads';
import fs from 'fs';
import path from 'path';
import { exposeAll, createCaller } from './rpc';
import { InterruptHandle, interrupt as nativeInterrupt } from 'interruptor';

const workerRuntimeSrcPath = path.resolve(__dirname, 'worker-runtime.js');

const workerProcess = new Worker(workerRuntimeSrcPath, { env: SHARE_ENV });
const workerProcess = new Worker(
// It's fine in this use-case: this process is spawned so we are not blocking
// anything in the main process
// eslint-disable-next-line no-sync
fs.readFileSync(workerRuntimeSrcPath, 'utf8'),
{ env: SHARE_ENV, eval: true }
);

// We expect the amount of listeners to be more than the default value of 10 but
// probably not more than ~25 (all exposed methods on
Expand Down