fix: change runtime importing approach MONGOSH-618 #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…throw if it's not available
…l so it can resolve external deps correctly
addaleax
approved these changes
Mar 3, 2021
Co-authored-by: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should finally allow us to include compass-shell with new runtime in compass without any issues. Current implementation doesn't work because
worker_threadsWorker when spawned in electron environment can't resolve anything correctly inside the.asarbundle, so worker code just fails when trying to resolveinterruptor(that needs to stay external because it has a native module dependency). As a workaround we will ensure that if we are trying to importnode-runtime-worker-threadfrom inside the.asararchive we would instead look for the unpacked version and hard fail if it doesn't exist as requiring one that is not unpacked would not work correctly anyway.