feat(cli-repl): add load() support MONGOSH-386 #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paired on this with Michael because it seemed like a good ticket to pair on and we’re going to be doing the loading-files epic soon.
rose-m
approved these changes
Mar 4, 2021
mcasimir
approved these changes
Mar 4, 2021
| }; | ||
|
|
||
| export type MongoshConfigProvider = { | ||
| export type MongoshIOProvider = { |
There was a problem hiding this comment.
just a non-important random observation: this type is getting to be a bit of a jack of all trades, did we consider having multiple interfaces that ties together only the methods that are naturally coupled?
There was a problem hiding this comment.
Yeah, so... we could definitely split it up, but I feel like this might be one of those things where it's okay to wait until we have a reason to do so (e.g. if we ever make MongoshRepl a public API, which seems possible)
No strong feelings though :)
There was a problem hiding this comment.
Yeah, me neither, keeping it like that is super fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired on this with Michael because it seemed like a good ticket to
pair on and we’re going to be doing the loading-files epic soon.