chore(cli-repl): (hopefully) fix flaky mongocryptd test #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example failure:
[2021/04/01 09:26:24.908] 1) MongocryptdManager
[2021/04/01 09:26:24.908] with network testing
[2021/04/01 09:26:24.908] performs keepalive pings:
[2021/04/01 09:26:24.908] SyntaxError: Unexpected end of JSON input
[2021/04/01 09:26:24.908] at JSON.parse (<anonymous>)
[2021/04/01 09:26:24.908] at Context.<anonymous> (src/mongocryptd-manager.spec.ts:184:19)
Presumably this is happening because the connections aren’t established
fast enough when the host is under load, e.g. because multiple tests
are running at the same time. Using the `eventually` helper would be
the right thing to do here anyway, because it allows for a longer
timeout while at the same time finishing faster under normal
circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failure:
Presumably this is happening because the connections aren’t established
fast enough when the host is under load, e.g. because multiple tests
are running at the same time. Using the
eventuallyhelper would bethe right thing to do here anyway, because it allows for a longer
timeout while at the same time finishing faster under normal
circumstances.