Skip to content

fix(node-runtime-worker-thread): reset require cache after interrupt … #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix(node-runtime-worker-thread): reset require cache after interrupt … #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/node-runtime-worker-thread/src/worker-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ const workerRuntime: WorkerRuntime = {

let interrupted = true;
let evaluationPromise: void | Promise<RuntimeEvaluationResult>;
const previousRequireCache = Object.keys(require.cache);

try {
evaluationPromise = runInterruptible((handle) => {
Expand All @@ -109,6 +110,17 @@ const workerRuntime: WorkerRuntime = {
});
} finally {
evaluationListener.onRunInterruptible(null);

if (interrupted) {
// If we were interrupted, we can't know which newly require()ed modules
// have successfully been loaded, so we restore everything to its
// previous state.
for (const key of Object.keys(require.cache)) {
if (!previousRequireCache.includes(key)) {
delete require.cache[key];
}
}
}
}

let result: void | RuntimeEvaluationResult | UNLOCKED;
Expand Down