Skip to content

Conversation

addaleax
Copy link
Collaborator

@addaleax addaleax commented Apr 9, 2021

No description provided.

@addaleax addaleax added the wip Work in Progress label Apr 9, 2021
Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach 👍 Would allow us to also provide different options / configs per environment (cli vs. compass) if I understood correctly 😄

@addaleax addaleax removed the wip Work in Progress label Apr 20, 2021
@addaleax addaleax changed the title WIP: global shell settings API MONGOSH-635 feat: add global shell settings API MONGOSH-635 Apr 20, 2021
@addaleax
Copy link
Collaborator Author

I like the approach +1 Would allow us to also provide different options / configs per environment (cli vs. compass) if I understood correctly smile

Yes, it would allow us to do that if we like 👍

Feel free to take another look, this has tests now and should be ready for review :)

Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@addaleax addaleax merged commit 002ff53 into master Apr 21, 2021
@addaleax addaleax deleted the 635-dev branch April 21, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants