fix(shell-api): fix prompt for Atlas-proxy-style mongos MONGOSH-680 #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connected to a server that we know is an Atlas server but announces itself as a mongos, print “atlas proxy” in the prompt rather than “mongos” to avoid confusion. As a drive-by fix, make sure to use the service provider of the current database, and not necessarily the initial one, as new connections can be assigned to `db`.
gribnoysup
approved these changes
Apr 22, 2021
| }); | ||
| return sp; | ||
| }); | ||
| sp.platform = 2; // ReplPlatform.CLI ... let's maybe stop using an enum for this |
There was a problem hiding this comment.
We can make it a string enum with some human readable values 😄
There was a problem hiding this comment.
Yeah … although I’d personally lean towards using something'cli' | 'java-shell' | 'compass' | 'browser' – I think this is one of those things @rose-m might have meant yesterday?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connected to a server that we know is an Atlas server but
announces itself as a mongos, print “atlas proxy” in the prompt
rather than “mongos” to avoid confusion.
As a drive-by fix, make sure to use the service provider of the
current database, and not necessarily the initial one, as new
connections can be assigned to
db.