chore(cli-repl): work around Node.js REPL bug MONGOSH-589 #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the fix in c8cee80, the test here is also flaky because of a Node.js REPL bug where `repl.displayPrompt()` was called twice after we reported an error, which confused the prompt detection in the shell and made the test flaky depending on whether both prompts where received in the same output data chunk or not. For now, just wait until both parts of the double prompt are present in the output before executing the next input line.
gribnoysup
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the fix in c8cee80, the test here is also flaky
because of a Node.js REPL bug where
repl.displayPrompt()was calledtwice after we reported an error, which confused the prompt detection
in the shell and made the test flaky depending on whether both prompts
where received in the same output data chunk or not.
For now, just wait until both parts of the double prompt are present
in the output before executing the next input line.