chore(shell-api): combine common Cursor + AbstractCursor code #809
Conversation
addaleax
force-pushed
the
dedupe-cursors
branch
from
52b9cc4 to
9ae519b
Compare
packages/i18n/src/locales/en_US.ts
Outdated
| } | ||
| }, | ||
| }, | ||
| AbstractCursor: { |
There was a problem hiding this comment.
Why is this necessary here? I don't think we want to make this class visible to the user in any way or?
Can we rather exclude this one with some annotation on the AbstractCursor class, something like @abstract or @nohelp?
There was a problem hiding this comment.
And of course i've tagged random users ... 🤦
There was a problem hiding this comment.
Can we rather exclude this one with some annotation on the AbstractCursor class, something like
@abstractor@nohelp?
Yes, let me try that (I think @gribnoysup’s #784 also has the potential to make this kind of thing much easier in the future)
There was a problem hiding this comment.
@mcasimir Okay, done :) Feel free to take another look
There was a problem hiding this comment.
Yeah, totally can take inheritance chains while ignoring those abstract classes into account when generating metadata
Create an `AbstractCursor` class (named like the driver equivalent) as a common base class for `Cursor` and `AggregationCursor` to reduce code duplication.
This helps with more code deduplication, because it can make wrappers go away that were only needed to re-specify the return type in a subclass.
addaleax
force-pushed
the
dedupe-cursors
branch
from
898e8f3 to
d819c29
Compare
3 participants
chore(shell-api): combine common Cursor + AbstractCursor code
Create an
AbstractCursorclass (named like the driver equivalent)as a common base class for
CursorandAggregationCursorto reduce code duplication.
chore(shell-api): allow
@returnType('this')This helps with more code deduplication, because it can make wrappers
go away that were only needed to re-specify the return type
in a subclass.