fix(shell-api): do not forward auth errors on completion MONGOSH-719 #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
reviewed
Apr 27, 2021
|
|
||
| it('completes the db.version method', async() => { | ||
| output = ''; | ||
| input.write('db.vers\u0009\u0009'); |
There was a problem hiding this comment.
Just super random thought .. we could have const TAB = "\u0009"; and db.vers${TAB}${TAB} or something .. not a life changing one :)
There was a problem hiding this comment.
Sounds good, we already do that for e.g. arrow-up in the other tests. I’ll do that right after merging this.
mcasimir
reviewed
Apr 27, 2021
| return collectionNames.filter((name) => name.startsWith(collName)); | ||
| } catch (err) { | ||
| if (err.code === ShellApiErrors.NotConnected) { | ||
| if (err.code === ShellApiErrors.NotConnected || err.codeName === 'Unauthorized') { |
There was a problem hiding this comment.
Should 'Unauthorized' be also part ShellApiErrors to be consistent with the other?
There was a problem hiding this comment.
This is not a shell error, though, it’s a server error :)
mcasimir
approved these changes
Apr 27, 2021
addaleax
added a commit
that referenced
this pull request
Apr 27, 2021
addaleax
added a commit
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.