Skip to content

fix(cli-repl): hide prompt if --eval throws async err MONGOSH-715 #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021
Merged

fix(cli-repl): hide prompt if --eval throws async err MONGOSH-715 #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a20519
fix(cli-repl): hide prompt if --eval throws async err MONGOSH-715
addaleax Apr 27, 2021
354635b
fixup: Let's see what CI says now :)
addaleax Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/cli-repl/src/mongosh-repl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,4 +710,18 @@ describe('MongoshNodeRepl', () => {
expect(output).to.contain('Atlas Data Lake > ');
});
});

context('before the REPL starts', () => {
beforeEach(async() => {
await mongoshRepl.initialize(serviceProvider);
// No .start() call here.
});

it('does not show a prompt', async() => {
await mongoshRepl.loadExternalCode('setImmediate(() => { throw new Error(); })', '<eval>');
await tick();
expect(output).to.include('Error: \n');
expect(output).not.to.include('>');
});
});
});
5 changes: 5 additions & 0 deletions packages/cli-repl/src/mongosh-repl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class MongoshNodeRepl implements EvaluationListener {
onClearCommand?: EvaluationListener['onClearCommand'];
insideAutoComplete: boolean;
inspectDepth = 0;
started = false;

constructor(options: MongoshNodeReplOptions) {
this.input = options.input;
Expand Down Expand Up @@ -151,6 +152,9 @@ class MongoshNodeRepl implements EvaluationListener {
const originalDisplayPrompt = repl.displayPrompt.bind(repl);

repl.displayPrompt = (...args: any[]) => {
if (!this.started) {
return;
}
originalDisplayPrompt(...args);
this.lineByLineInput.nextLine();
};
Expand Down Expand Up @@ -242,6 +246,7 @@ class MongoshNodeRepl implements EvaluationListener {

// eslint-disable-next-line @typescript-eslint/no-unused-vars
async startRepl(_initializationToken: InitializationToken): Promise<void> {
this.started = true;
const { repl, internalState } = this.runtimeState();
// Only start reading from the input *after* we set up everything, including
// internalState.setCtx().
Expand Down