fix(shell-api): sharding methods account for 5.0 config.chunks change… #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
May 3, 2021
| databases.sort((a: any, b: any): any => { | ||
| return a._id > b._id; | ||
| databases.sort((a: any, b: any): number => { | ||
| return a._id.localeCompare(b._id); |
There was a problem hiding this comment.
Just something I noticed, this would obviously not have worked before because the .sort() callback should not return a boolean.
| { $sort: { shard: 1 } }) | ||
| ).toArray(); | ||
| { $sort: { shard: 1 } } | ||
| ])).toArray(); |
There was a problem hiding this comment.
The tests really should have discovered that sh.status() was also broken, I just noticed this because I was looking for other uses of config.chunks in the shell-api source. I’ve opened https://jira.mongodb.org/browse/MONGOSH-742 as a reminder to write proper tests here.
rose-m
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s MONGOSH-740