fix(cli-repl): work around double-prompt Node.js REPL bug MONGOSH-727 #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
approved these changes
May 4, 2021
Since the bug has more implications than making our tests flaky, start working around it instead of skipping tests. In particular, this fixes the linked ticket, because the REPL implementation calling `repl.displayPrompt()` twice after an error would also call `lineByLineInput.nextLine()` twice in our code, which would start two async evaluations happening at the same time, which breaks the async REPL wrapper’s API contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bug has more implications than making our tests flaky, start
working around it instead of skipping tests.
In particular, this fixes the linked ticket, because the REPL
implementation calling
repl.displayPrompt()twice after an errorwould also call
lineByLineInput.nextLine()twice in our code,which would start two async evaluations happening at the same time,
which breaks the async REPL wrapper’s API contract.