fix(cli-repl): aggregate regular characters in LineByLineInput MONGOS… #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-687 Instead of forwarding characters one-by-one to the REPL/readline instance, group characters that do not have special meaning in a REPL context together. This is relevant when pasting strings, where multiple characters are read in rapid succession, and makes the REPL behave a bit more closely to what e.g. the Node.js REPL does in that case. There are two main advantages of this: - This makes tab-indented code behave well, because the REPL does not trigger autocompletion when seeing `\tstring`, only when seeing `\t` and `string` separately. - This makes input handling a bit faster, because e.g. the input highlighting needs to perform fewer operations for pasted code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…H-687
Instead of forwarding characters one-by-one to the REPL/readline
instance, group characters that do not have special meaning in a
REPL context together. This is relevant when pasting strings,
where multiple characters are read in rapid succession, and makes
the REPL behave a bit more closely to what e.g. the Node.js REPL
does in that case. There are two main advantages of this:
not trigger autocompletion when seeing
\tstring, only whenseeing
\tandstringseparately.highlighting needs to perform fewer operations for pasted code.