feat(build): add macos arm64 support MONGOSH-442 #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
force-pushed
the
442-dev
branch
2 times, most recently
from
7333951 to
6c80b4a
Compare
addaleax
force-pushed
the
442-dev
branch
2 times, most recently
from
8821cc0 to
c6a160a
Compare
mcasimir
approved these changes
May 19, 2021
| fsConstants.COPYFILE_FICLONE); | ||
| } else { | ||
| await fs.copyFile( | ||
| path.resolve(__dirname, '..', '..', '..', '..', 'scripts', 'no-mongocryptd.sh'), |
There was a problem hiding this comment.
How is this going to work? Will it affect something that mongosh does automatically or is rather there if users tries to run mongocryptd manually?
There was a problem hiding this comment.
Yeah, mongosh won’t be able to do automatic FLE for the time being. The exposed binary is still named mongocryptd-mongosh, so I don’t think it’s something the user would run by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.