Skip to content

feat(cli-repl): include API version in greeting message #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021
Merged

feat(cli-repl): include API version in greeting message #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/cli-repl/src/mongosh-repl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,11 @@ class MongoshNodeRepl implements EvaluationListener {
internalState.setEvaluationListener(this);
await internalState.fetchConnectionInfo();

const mongodVersion = internalState.connectionInfo.buildInfo?.version;
let mongodVersion = internalState.connectionInfo.buildInfo?.version;
const apiVersion = serviceProvider.getRawClient()?.serverApi?.version;
if (apiVersion) {
mongodVersion = (mongodVersion ? mongodVersion + ' ' : '') + `(API Version ${apiVersion})`;
}
await this.greet(mongodVersion);
await this.printStartupLog(internalState);

Expand Down
16 changes: 16 additions & 0 deletions packages/cli-repl/test/e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,22 @@ describe('e2e', function() {
`${await testServer.connectionString()}/${dbName}`, '--apiVersion', '1'
] });
await shell.waitForPrompt();
shell.assertContainsOutput('(API Version 1)');
expect(await shell.executeLine('db.coll.find().toArray()'))
.to.include('[]');
shell.assertNoErrors();
});

it('can specify an API version and strict mode', async function() {
// Disable this until https://jira.mongodb.org/browse/NODE-3183
// is done because the server has started requiring hello instead of
// isMaster.
return this.skip();
const shell = TestShell.start({ args: [
`${await testServer.connectionString()}/${dbName}`, '--apiVersion', '1', '--apiStrict', '--apiDeprecationErrors'
] });
await shell.waitForPrompt();
shell.assertContainsOutput('(API Version 1)');
expect(await shell.executeLine('db.coll.find().toArray()'))
.to.include('[]');
shell.assertNoErrors();
Expand Down