feat(cli-repl): fix files as positional arguments and add --file MONGOSH-769 #890
Conversation
…OSH-769 - If the first positional argument ends in .mongo or .js and is not a connection string, treat it as a filename. - Add a `--file` (`-f`) flag for specifying filenames that avoids this ambiguity. - Internally, avoid referring to positional arguments in general and be specific about whether the connection specifier or the filenames are being accessed - As drive-by fixes, fix the spelling of `tlsAllowInvalidHostname` and drop the extra unnecessary `start` argument handling.
I’m not sure, I think this would be a fairly frequently used feature and it might make sense to change the documentation first (and show a deprecation notice there). |
| if (arg.startsWith('-')) { | ||
| throw new Error( | ||
| ` ${clr(i18n.__(UNKNOWN), ['red', 'bold'])} ${clr(String(arg), 'bold')} | ||
| ${USAGE}` | ||
| ); |
There was a problem hiding this comment.
Not really related to this change, but I was figuring out what case this is handling and found an interesting uhhh... bug? related to how yargs parser works I guess
This exists with unknown option error
mongosh --------foobar
This doesn't exit, the option is parsed by yargs to --------help: true so no help is printed
mongosh ----------help
There was a problem hiding this comment.
That”s … interesting, yeah. I feel like this might even qualify as yargs bug
There was a problem hiding this comment.
Yeah, true, I'll take a look if they have something like this already submitted and will open an issue/send a patch or something. I think it's a big enough corner case for us to not really worry about 🤔
| // All positional arguments are either in connectionSpecifier or fileNames, | ||
| // and should only be accessed that way now. | ||
| delete parsed._; |
There was a problem hiding this comment.
Introducing this legacy shell behavior was worth it if only for this change, makes it nice and explicit 👏
3 participants
(includes #887 and commits from main for passing CI/avoiding conflicts, only the last commit is original here)
connection string, treat it as a filename.
--file(-f) flag for specifying filenames that avoids thisambiguity.
be specific about whether the connection specifier or the filenames
are being accessed
tlsAllowInvalidHostnameanddrop the extra unnecessary
startargument handling.