Skip to content

fix(cli-repl): do not throw internal errors for invalid user code MONGOSH-777 #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

fix(cli-repl): do not throw internal errors for invalid user code MONGOSH-777 #895

merged 1 commit into from
May 21, 2021

Conversation

rose-m
Copy link
Contributor

@rose-m rose-m commented May 21, 2021

No description provided.

@rose-m rose-m self-assigned this May 21, 2021
addaleax
addaleax approved these changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense 👍

@rose-m
Copy link
Contributor Author

rose-m commented May 21, 2021

Took me a while to find the reason since it showed SyntaxError 😅 But finally found it since the stack trace came from different packages...

@rose-m rose-m merged commit a3f993f into main May 21, 2021
@rose-m rose-m deleted the MONGOSH-777-internal-errors-for-user-code branch May 21, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

@rose-m rose-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rose-m @addaleax