feat(shell-api): add reconfigForPSASet helper MONGOSH-702 #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the same functionality as the newly introduced legacy
shell equivalent.
Notable differences are:
- This does some type cleanup around the replset code
- This is more verbose, and prints:
- A warning if the new member is already in the existing config
with a different _id but the same hostname
- Indicators that retrying is still going on when it is
- The second reconfig commmand, if it failed, so that the user
can retry manually
- This performs exponential backoff while waiting for the second
reconfig to succeed
- This uses a fixed number of attempts (12) instead of a fixed
duration (90 seconds) for performing the second reconfig
rose-m
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the same functionality as the newly introduced legacy
shell equivalent.
Notable differences are:
with a different _id but the same hostname
can retry manually
reconfig to succeed
duration (90 seconds) for performing the second reconfig