fix(service-provider-core): allow non-hostname chars in DB name MONGOSH-792 #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SH-792 This also means that e.g. `host:port?option=value` is not allowed, and instead any optional part after the port in the non-URL variant needs to be separated by a slash (which was also the case in the legacy shell).
addaleax
commented
May 26, 2021
| it('when specifying multiple seeds through --host with a wrong replsetid', async() => { | ||
| const hostlist = 'wrongreplset/' + await rs2.hostport() + ',' + await rs1.hostport() + ',' + await rs0.hostport(); | ||
| const shell = TestShell.start({ args: ['--host', hostlist, 'admin?serverSelectionTimeoutMS=2000'] }); | ||
| const shell = TestShell.start({ args: ['--host', hostlist, 'admin'] }); |
There was a problem hiding this comment.
The legacy shell would have interpreted the previous string as an entire database name here (and it would be a valid one)
| if (connectionString.hosts.length === 1 && | ||
| ['localhost', '127.0.0.1'].includes(connectionString.hosts[0].split(':')[0])) { | ||
| if (connectionString.hosts.every(host => | ||
| ['localhost', '127.0.0.1'].includes(host.split(':')[0]))) { |
There was a problem hiding this comment.
This is more of a drive-by change to account for the fact that the e2e-direct test cannot use serverSelectionTimeoutMS directly anymore, but I feel like it still just makes sense
rose-m
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also means that e.g.
host:port?option=valueis not allowed,and instead any optional part after the port in the non-URL variant
needs to be separated by a slash (which was also the case in
the legacy shell).