fix(cli-repl): set terminal window title MONGOSH-725 #918
Conversation
packages/cli-repl/src/run.ts
Outdated
| const driverUri = generateUri(options); | ||
|
|
||
| process.title = `mongosh ${redactCredentials(driverUri)}`; | ||
| setTerminalWindowTitle(process.title); |
There was a problem hiding this comment.
Since process.title is a getter/setter that actually queries the current process title (which might differ from what we have just set it to, for example, because it was truncated or because setting process.title isn’t available on the current platform), I think it makes sense to store the title in a variable and then set it both with setTerminalWindowTitle and process.title separately.
There was a problem hiding this comment.
O.o I didn't know that might actually change otherwise!
There was a problem hiding this comment.
Yeah … the problem is that on UNIX systems, this actually works by overwriting the original argv array that was passed to main; and so the maximum length of process.title is also the maximum length of the original command line:
$ node
Welcome to Node.js v17.0.0-pre.
Type ".help" for more information.
> process.title = 'a'.repeat(100)
'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
> process.title.length
4
rose-m
force-pushed
the
MONGOSH-725-set-terminal-window-title
branch
from
8ef93cd to
a30201e
Compare
No description provided.