Skip to content

Conversation

addaleax
Copy link
Collaborator

For context, the original motivation here was that for snippets,
if we change the default index URL, users should receive that change
if they have not explicitly changed the config themselves.

For context, the original motivation here was that for snippets,
if we change the default index URL, users should receive that change
if  they have not explicitly changed the config themselves.
Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I somehow find the wording not entirely correct as it's more a "only store explicitly set config options to disk". For the "non-default" I'd had expected it to only store it to disk when the actual value diverges from the default setting.

@addaleax
Copy link
Collaborator Author

For the "non-default" I'd had expected it to only store it to disk when the actual value diverges from the default setting.

Yeah, I’m also not particularly sure what the expected behavior there is – if you set it to (a value that happens to be) the default value, and then we change the default, what would the right value afterwards?

@rose-m
Copy link
Contributor

rose-m commented May 31, 2021

That's exactly what I was thinking about... but yeah I'm totally fine with the semantics of "if you set the value explicitely, it will stay like that".

@addaleax addaleax merged commit 562aa7d into main May 31, 2021
@addaleax addaleax deleted the 794-dev branch May 31, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants