feat(cli-repl): add redactHistory config option MONGOSH-603 #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the undocumented, untested `--redactInfo` CLI flag and offer a config option with three possible values: - `keep`: Retain the history as-is - `remove`: Remove lines with sensitive commands - `remove-redact`: `remove` + redact sensitive data from non-sensitive commands (e.g. email addresses)
rose-m
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the undocumented, untested
--redactInfoCLI flag and offera config option with three possible values:
keep: Retain the history as-isremove: Remove lines with sensitive commandsremove-redact:remove+ redact sensitive data from non-sensitivecommands (e.g. email addresses)