fix(shell-api): improve rs.reconfig helper for 5.0 changes MONGOSH-785 #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
force-pushed
the
MONGOSH-785-unskip-rs-integration-tests
branch
from
c7edfd7 to
90709c4
Compare
rose-m
changed the title
addaleax
approved these changes
Jun 7, 2021
| // Strip -rc.0, -alpha, etc. from the server version because semver rejects those otherwise. | ||
| testServerVersion = testServerVersion.replace(/-.*$/, ''); | ||
| if (semver.satisfies(testServerVersion, semverCondition)) { | ||
| if (semver.satisfies(testServerVersion, semverCondition, { includePrerelease: true })) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll adjust the tests so that the
reconfigmethods gets the full tests on backoff etc. that are currently on thereconfigPSASet.