-
Notifications
You must be signed in to change notification settings - Fork 79
feat(service-provider-server): add kerberos addon MONGOSH-823 #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
try { | ||
try { | ||
try { | ||
shell.assertContainsOutput('Unspecified GSS failure'); | ||
} catch { | ||
shell.assertContainsOutput('Error from KDC'); | ||
} | ||
} catch { | ||
shell.assertContainsOutput('No credentials cache file found'); | ||
} | ||
} catch { | ||
shell.assertContainsOutput('The logon attempt failed'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omg this assertion 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I’m not sure that this is actually exhaustive yet… but all of these indicate that the kerberos addon actually tried to do something :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
cc0bf4f
to
76d2ccf
Compare
# executable compilation step. | ||
npm --unsafe-perm=true run bootstrap-ci -- --scope @mongosh/build | ||
npm --unsafe-perm=true run bootstrap-ci -- --scope @mongosh/cli-repl --include-dependencies || \ | ||
(npm --unsafe-perm=true run bootstrap-ci -- --scope @mongosh/cli-repl --include-dependencies --ignore-scripts && npm --unsafe-perm=true run compile-cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context: This was working with mongodb-client-encryption@1.2.3, because that included a deps
folder with the necessary headers and library files to build a broken version of the addon (the library files were only actually working on x64 macOS, but they could still be linked on most platforms and we don’t need a functional mongodb-client-encryption addon to build the executable, only one with the proper source code + types)
…e krb error messages
This is WIP because it turns out there’s actually a conflict between theInit
functions of the libmongocryptd bindings and the kerberos addon, because they are not declared asstatic
. That’s something for tomorrow, though :)Tomorrow has happened and now that bug is gone thanks to the Node.js driver team :)