Skip to content

Conversation

addaleax
Copy link
Collaborator

@addaleax addaleax commented Jun 9, 2021

This is WIP because it turns out there’s actually a conflict between the Init functions of the libmongocryptd bindings and the kerberos addon, because they are not declared as static. That’s something for tomorrow, though :)

Tomorrow has happened and now that bug is gone thanks to the Node.js driver team :)

@addaleax addaleax changed the title [WIP] feat(service-provider-server): add kerberos addon MONGOSH-823 feat(service-provider-server): add kerberos addon MONGOSH-823 Jun 10, 2021
Comment on lines 1009 to 1029
try {
try {
try {
shell.assertContainsOutput('Unspecified GSS failure');
} catch {
shell.assertContainsOutput('Error from KDC');
}
} catch {
shell.assertContainsOutput('No credentials cache file found');
}
} catch {
shell.assertContainsOutput('The logon attempt failed');
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg this assertion 😃

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I’m not sure that this is actually exhaustive yet… but all of these indicate that the kerberos addon actually tried to do something :)

Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@addaleax
Copy link
Collaborator Author

addaleax commented Jun 10, 2021

(CI might only start working later, when prebuilt binaries are available here) Yes and no. This is going to require at least changes to add libkrb5 to some testing environments.

@addaleax addaleax force-pushed the 823-dev branch 4 times, most recently from cc0bf4f to 76d2ccf Compare June 11, 2021 13:01
# executable compilation step.
npm --unsafe-perm=true run bootstrap-ci -- --scope @mongosh/build
npm --unsafe-perm=true run bootstrap-ci -- --scope @mongosh/cli-repl --include-dependencies || \
(npm --unsafe-perm=true run bootstrap-ci -- --scope @mongosh/cli-repl --include-dependencies --ignore-scripts && npm --unsafe-perm=true run compile-cli)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context: This was working with mongodb-client-encryption@1.2.3, because that included a deps folder with the necessary headers and library files to build a broken version of the addon (the library files were only actually working on x64 macOS, but they could still be linked on most platforms and we don’t need a functional mongodb-client-encryption addon to build the executable, only one with the proper source code + types)

@addaleax addaleax merged commit 9cf507b into main Jun 14, 2021
@addaleax addaleax deleted the 823-dev branch June 14, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants