VSCODE-122: Playground through SSH connection #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
changed the title
Anemy
approved these changes
May 18, 2020
There was a problem hiding this comment.
lgtm. We can pull this ssh driver for the launch shell command in https://jira.mongodb.org/browse/VSCODE-115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bamp
connection-modelanddata-servicedependencies that include ssh fix for a playground. The new version of the connection model exposes URL with SSH tunnel port injected. Since we do not use data service in the language server we need SSH injection before sending the connection string to CliServiceProvider.Issue: #97
Checklist
Motivation and Context
Types of changes