Skip to content

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented May 20, 2020

Description

  • Provide connection string with ssh tunnel port injected when connecting via shell.
  • Fix auth when connecting with driverUrlWithSsh. Use real password instead of safe password.
  • Use '<ssh host>:<ssh port>' as default name for saved ssh connections.
  • Bamp mongosh version to 0.0.1-alpha.17.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika changed the title VSCODE-124: connect with ssh to shell VSCODE-124: Connect with ssh to shell May 20, 2020
@alenakhineika alenakhineika requested a review from Anemy May 20, 2020 15:24
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tested sshing into another device and worked smooth 👍
Good naming on the connections and thanks for adding a test & bamping mongosh.

@alenakhineika alenakhineika merged commit 2be1e0d into master May 25, 2020
@alenakhineika alenakhineika deleted the VSCODE-124-connect-with-ssh-to-shell branch May 25, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants