VSCODE-56: Display document count in tree view #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
approved these changes
Jul 21, 2020
| }; | ||
|
|
||
| export const formatDocCount = (count: number): string => { | ||
| return `${numeral(count).format('0a')}`.toUpperCase(); |
There was a problem hiding this comment.
Could you pls add a comment with an example here to make it move visible what the expected format should be.
| `Expected a tree item child with the label "show more..." found ${documents[10].label}` | ||
| ); | ||
| }) | ||
| .then(done, done); |
There was a problem hiding this comment.
Always happy to see that done done disappears 😀
| ); | ||
| // Here we stub the showInformationMessage process because it is too much | ||
| // for the render process and leads to crashes while testing. | ||
| sinon.replace(vscode.window, 'showInformationMessage', sinon.stub()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/VSCODE-56
This PR adds a document count in the tree view. The count is shown in the document lists' description. When the document count is a large number it's abbreviated using numeral js (Compass also uses this). Chatted with Claudia and Max and we were preferring uppercase abbreviations over lowercase (
kvsK,mvsM), so they're shown in uppercase, any thoughts?When the document list is hovered, the tooltip shows the full document count.
Also added a
Refreshright-click action to the document list to reset it in the tree view.