Skip to content

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jul 30, 2020

Description

  • Add the search icon to the documents list
  • Click on the search icon opens a playground with the search template
  • Add the Search for documents item to the context menu

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika requested a review from Anemy July 30, 2020 14:54
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good - this is some good functionality, and it's really nice we're bring more functionality introducing users into playgrounds.

One small thing, then lgtm. Also maybe we can bring the size of the search down a bit, we can sync with design and get it nice like you said.

I think we want to add a rule for the mdb.searchForDocuments command so it doesn't show up in the commandPalette

    "commandPalette": [
        {
          "command": "mdb.searchForDocuments",
          "when": "false"
        },

@alenakhineika
Copy link
Contributor Author

@Anemy removed mdb.searchForDocuments from the command palette, nice catch! Left the icon without changes because it has the same size as the plus icon for connections.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm!

@alenakhineika alenakhineika merged commit 814dc4c into master Jul 31, 2020
@alenakhineika alenakhineika deleted the VSCODE-158-search-for-documents branch July 31, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants