-
Notifications
You must be signed in to change notification settings - Fork 89
VSCODE-86: Playgrounds and connections explorers update #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCODE-86: Playgrounds and connections explorers update #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good. nice. I see this getting a lot of good use. Nice work adding the setting for folder/file exclusions too - with wildcards! Left two small questions/ideas.
Also if it isn't too much work, maybe we could add one more test to the playgroundsExplorer.test.ts
to make sure we're using the excludeFromPlaygroundsSearch
setting correctly (more just to future proof us against small changes that might change behavior unexpectedly).
Something I need to test at some point - or have you done this by chance - is to make sure when the settings for the views are disabled like mdb.showMongoDBConnectionExplorer
are set to false (the views are hidden) that vscode doesn't call getChildren
on the views.
package.json
Outdated
"title": "Refresh" | ||
}, | ||
{ | ||
"command": "mdb.createPlaygroundFromTreeView", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use this command currently? Looks like it might be an extra.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this comment - then lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, i thought i deleted it! Now deleted for sure :)
@Anemy I tested Updated PR to address other comments, thx for the valuable feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small command tweak that's in the command palette, otherwise lgtm!
Nice work on this.
"title": "MongoDB: Create MongoDB Playground" | ||
}, | ||
{ | ||
"command": "mdb.refreshPlaygrounds", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think this one makes it into the command palette.
...
"editor/title": [{
"command": "mdb. refreshPlaygrounds",
"when": "false"
}
...]
Is it something we want in the command palette? In that case maybe we could add a command for that which has the MongoDB:
prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added additional command for refreshing playgrounds from the command palette in addition to one is being called from the tree view. Plus test for it.
…and command palette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
.mongodb
files in the current workspace including all nested folders and excluding folders and files specified in MongoDB extension settingsChecklist
Motivation and Context
Types of changes