VSCODE-163: Add resources/help panel #166
Conversation
There was a problem hiding this comment.
Yeah, it would be nice to play with icon's sizes. Now also because they have a different shape, they look sometimes much bigger than text, or very small like MongoDB leaf. Looking forward to seeing the final version! This help panel should be very useful for users.
|
|
||
| deactivate(): void { | ||
| if (this._treeView) { | ||
| this._treeView.dispose(); |
There was a problem hiding this comment.
Just wonder what will happen if we do not dispose when deactivate?
There was a problem hiding this comment.
From what I understand, disposing cleans up the listeners we create in activateTreeViewEventHandlers (treeView.onDidChangeSelection)
https://vscode-docs.readthedocs.io/en/stable/extensions/patterns-and-principles/#disposables
I think it's something we want to keep, just to make sure we clean up a bit.
| }; | ||
|
|
||
| public async activatePlaygroundsTreeView(): Promise<void> { | ||
| public activatePlaygroundsTreeView(): void { |
|
|
||
| const micromatch = require('micromatch'); | ||
| const log = createLogger('explorer controller'); | ||
| const log = createLogger('playgrounds tree controller'); |
| ? vscode.FileType.Directory | ||
| : this.fsStat.isSymbolicLink() | ||
| ? vscode.FileType.SymbolicLink | ||
| : vscode.FileType.Unknown; |
There was a problem hiding this comment.
Do you have any additional settings in your vscode different from what we have in .vscode/settings.json?
There was a problem hiding this comment.
Eslint is doing this one - it's also complaining that it's too many layers of ternary 😅
| } | ||
|
|
||
| private getFileNames(path: string): Promise<string[]> { | ||
| private getFileNames(filePath: string): Promise<string[]> { |
|
Tested links and collapsing state, everything works well! When tests are fixed and icons updated can be merged 👌 |
2 participants
This PR adds a Help and Feedback panel with links to different resources:
Open qs:
Tweaking the icons still a bit with Claudia, figured I'd open the PR now since its mostly styles.