Skip to content

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Sep 21, 2020

Description

Change the logic to show code lenses above the selected block of text instead of showing them below the selection. According to VSCode API code lenses always appear above the specified line, therefore if there is no empty line below the selected block of text, there is no entry point for code lenses to appear above and code lenses are missing.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika requested a review from Anemy September 21, 2020 11:35
Copy link
Member

@mmarcon mmarcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alenakhineika alenakhineika merged commit 235f7fd into master Sep 21, 2020
@alenakhineika alenakhineika deleted the VSCODE-175-code-lenses-before-playground-block branch September 21, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants