VSCODE-172: Bump mongosh version to 0.4.0 #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Sep 24, 2020
|
hmmm in the built .vsix the built language server is not resolving the acorn plugins. Looking into and fixing before merging. Probably will wait to release till monday then. |
|
Looks like it something we need to change on mongosh to make sure we use the acorn dependencies correctly, we can pull in a new version of mongosh once we merge in this pr and release: mongodb-js/mongosh#344 (Tests expected to fail) |
added 2 commits
October 1, 2020 11:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.1-alpha.19 -> ^0.4.0
Using the new future mongosh.
Fixed a couple lints warns and updated vscode stubs with new variables in the interface.
Added acorn plugins to the webpack externals since webpack was using its version of acorn and overriding the ones the shell api is pulling in resulting in an error. *Didn't investigate deeper if its something we could update in mongosh, will do that a little now.
Here's where the acorn plugins are pulled in: https://github.com/mongodb-js/mongosh/blob/master/packages/async-rewriter/src/await.js#L9