fix(help-explorer): remove extra data provider tree register VSCODE-343 #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-343
Doesn't need to be in release notes as the bug wasn't released. Looks like we added an extra
registerTreeDataProviderto the help tree although it is already registered in the previous lines when we pass thetreeDataProvidertocreateTreeView. This resulted in it not handling the tree selections (no link clicks).https://github.com/mongodb-js/vscode/pull/437/files#diff-9bc69eef7e7b5c6202fdac33a5f439e7ca8be35d80a56724d4b49b3e6c7f38f6R26
More on tree data providers: https://code.visualstudio.com/api/extension-guides/tree-view#registering-the-treedataprovider