refactor: tests and commands clean up VSCODE-383 Tests and command palette clean up

package.json

@@ -108,7 +108,7 @@
       },
       {
         "view": "mongoDBPlaygroundsExplorer",
-        "contents": "No '.mongodb' playground files found in the workspace.\n[Create New Playground](command:mdb.createNewPlaygroundFromPlaygroundExplorer)"
+        "contents": "No MongoDB playground files found in the workspace.\n[Create New Playground](command:mdb.createNewPlaygroundFromTreeView)"
       }
     ],
     "languages": [
@@ -175,10 +175,6 @@
         "command": "mdb.createPlayground",
         "title": "MongoDB: Create MongoDB Playground"
       },
-      {
-        "command": "mdb.refreshPlaygrounds",
-        "title": "MongoDB: Refresh Playgrounds List"
-      },
       {
         "command": "mdb.refreshPlaygroundsFromTreeView",
         "title": "Refresh",
@@ -187,16 +183,12 @@
           "dark": "images/dark/refresh.svg"
         }
       },
-      {
-        "command": "mdb.createNewPlaygroundFromViewAction",
-        "title": "Create MongoDB Playground"
-      },
       {
         "command": "mdb.createNewPlaygroundFromOverviewPage",
         "title": "Create MongoDB Playground"
       },
       {
-        "command": "mdb.createNewPlaygroundFromPlaygroundExplorer",
+        "command": "mdb.createNewPlaygroundFromTreeView",
         "title": "Create MongoDB Playground",
         "icon": {
           "light": "images/light/add.svg",
@@ -296,7 +288,7 @@
         }
       },
       {
-        "command": "mdb.openPlaygroundFromTreeItem",
+        "command": "mdb.openPlaygroundFromTreeView",
         "title": "Open Playground"
       },
       {
@@ -407,11 +399,7 @@
     "menus": {
       "view/title": [
         {
-          "command": "mdb.createNewPlaygroundFromViewAction",
-          "when": "view == mongoDBPlaygroundsExplorer"
-        },
-        {
-          "command": "mdb.createNewPlaygroundFromPlaygroundExplorer",
+          "command": "mdb.createNewPlaygroundFromTreeView",
           "when": "view == mongoDBPlaygroundsExplorer",
           "group": "navigation@1"
         },
@@ -476,7 +464,7 @@
           "group": "5@2"
         },
         {
-          "command": "mdb.openPlaygroundFromTreeItem",
+          "command": "mdb.openPlaygroundFromTreeView",
           "when": "view == mongoDBPlaygroundsExplorer && viewItem == playgroundsTreeItem",
           "group": "1@1"
         },
@@ -630,6 +618,10 @@
         }
       ],
       "commandPalette": [
+        {
+          "command": "mdb.disconnect",
+          "when": "mdb.connectedToMongoDB == true"
+        },
         {
           "command": "mdb.saveMongoDBDocument",
           "when": "editorLangId == json"
@@ -644,23 +636,23 @@
         },
         {
           "command": "mdb.exportToRuby",
-          "when": "mdb.isPlayground == true"
+          "when": "mdb.isPlayground == true && mdb.connectedToMongoDB == true"
         },
         {
           "command": "mdb.exportToPython",
-          "when": "mdb.isPlayground == true"
+          "when": "mdb.isPlayground == true && mdb.connectedToMongoDB == true"
         },
         {
           "command": "mdb.exportToJava",
-          "when": "mdb.isPlayground == true"
+          "when": "mdb.isPlayground == true && mdb.connectedToMongoDB == true"
         },
         {
           "command": "mdb.exportToCsharp",
-          "when": "mdb.isPlayground == true"
+          "when": "mdb.isPlayground == true && mdb.connectedToMongoDB == true"
         },
         {
           "command": "mdb.exportToNode",
-          "when": "mdb.isPlayground == true"
+          "when": "mdb.isPlayground == true && mdb.connectedToMongoDB == true"
         },
         {
           "command": "mdb.refreshPlaygroundsFromTreeView",
@@ -678,16 +670,12 @@
           "command": "mdb.addConnectionWithURI",
           "when": "false"
         },
-        {
-          "command": "mdb.createNewPlaygroundFromViewAction",
-          "when": "false"
-        },
         {
           "command": "mdb.createNewPlaygroundFromOverviewPage",
           "when": "false"
         },
         {
-          "command": "mdb.createNewPlaygroundFromPlaygroundExplorer",
+          "command": "mdb.createNewPlaygroundFromTreeView",
           "when": "false"
         },
         {
@@ -715,7 +703,7 @@
           "when": "false"
         },
         {
-          "command": "mdb.openPlaygroundFromTreeItem",
+          "command": "mdb.openPlaygroundFromTreeView",
           "when": "false"
         },
         {

src/commands/index.ts

@@ -26,18 +26,16 @@ enum EXTENSION_COMMANDS {
   MDB_SAVE_MONGODB_DOCUMENT = 'mdb.saveMongoDBDocument',
 
   MDB_CHANGE_ACTIVE_CONNECTION = 'mdb.changeActiveConnection',
-  MDB_REFRESH_PLAYGROUNDS = 'mdb.refreshPlaygrounds',
 
   MDB_CODELENS_SHOW_MORE_DOCUMENTS = 'mdb.codeLens.showMoreDocumentsClicked',
 
   // Commands from the tree view.
   MDB_ADD_CONNECTION = 'mdb.addConnection',
   MDB_ADD_CONNECTION_WITH_URI = 'mdb.addConnectionWithURI',
   MDB_REFRESH_PLAYGROUNDS_FROM_TREE_VIEW = 'mdb.refreshPlaygroundsFromTreeView',
-  MDB_OPEN_PLAYGROUND_FROM_TREE_VIEW = 'mdb.openPlaygroundFromTreeItem',
+  MDB_OPEN_PLAYGROUND_FROM_TREE_VIEW = 'mdb.openPlaygroundFromTreeView',
   MDB_CONNECT_TO_CONNECTION_TREE_VIEW = 'mdb.connectToConnectionTreeItem',
-  MDB_CREATE_PLAYGROUND_FROM_VIEW_ACTION = 'mdb.createNewPlaygroundFromViewAction',
-  MDB_CREATE_PLAYGROUND_FROM_PLAYGROUND_EXPLORER = 'mdb.createNewPlaygroundFromPlaygroundExplorer',
+  MDB_CREATE_PLAYGROUND_FROM_TREE_VIEW = 'mdb.createNewPlaygroundFromTreeView',
   MDB_DISCONNECT_FROM_CONNECTION_TREE_VIEW = 'mdb.disconnectFromConnectionTreeItem',
   MDB_REFRESH_CONNECTION = 'mdb.refreshConnection',
   MDB_COPY_CONNECTION_STRING = 'mdb.copyConnectionString',

src/connectionController.ts

@@ -491,6 +491,12 @@ export default class ConnectionController {
     // Send metrics to Segment
     this.sendTelemetry(dataService, connectionType);
 
+    void vscode.commands.executeCommand(
+      'setContext',
+      'mdb.connectedToMongoDB',
+      true
+    );
+
     return {
       successfullyConnected: true,
       connectionErrorMessage: '',
@@ -570,6 +576,12 @@ export default class ConnectionController {
       await this._activeDataService.disconnect();
       void vscode.window.showInformationMessage('MongoDB disconnected.');
       this._activeDataService = null;
+
+      void vscode.commands.executeCommand(
+        'setContext',
+        'mdb.connectedToMongoDB',
+        false
+      );
     } catch (error) {
       // Show an error, however we still reset the active connection to free up the extension.
       void vscode.window.showErrorMessage(

src/editors/playgroundController.ts

@@ -598,7 +598,7 @@ export default class PlaygroundController {
       !isPlayground(this._activeTextEditor.document.uri)
     ) {
       void vscode.window.showErrorMessage(
-        "Please open a '.mongodb' playground file before running it."
+        'Please open a MongoDB playground file before running it.'
       );
 
       return Promise.resolve(false);
@@ -616,7 +616,7 @@ export default class PlaygroundController {
       !isPlayground(this._activeTextEditor.document.uri)
     ) {
       void vscode.window.showErrorMessage(
-        "Please open a '.mongodb' playground file before running it."
+        'Please open a MongoDB playground file before running it.'
       );
 
       return Promise.resolve(false);

src/explorer/collectionTreeItem.ts

@@ -83,6 +83,8 @@ export default class CollectionTreeItem
 
   isDropped = false;
 
+  iconPath: { light: string; dark: string };
+
   constructor(
     collection: CollectionModelType,
     databaseName: string,

src/explorer/documentListTreeItem.ts

@@ -108,6 +108,8 @@ export default class DocumentListTreeItem
 
   isExpanded: boolean;
 
+  iconPath: { light: string; dark: string };
+
   constructor(
     collectionName: string,
     databaseName: string,

src/explorer/fieldTreeItem.ts

@@ -173,6 +173,8 @@ export default class FieldTreeItem
 
   isExpanded: boolean;
 
+  iconPath: string | { light: string; dark: string };
+
   constructor(
     field: SchemaFieldType,
     isExpanded: boolean,

src/explorer/schemaTreeItem.ts

@@ -59,6 +59,8 @@ export default class SchemaTreeItem
   hasClickedShowMoreFields: boolean;
   hasMoreFieldsToShow: boolean;
 
+  iconPath: { light: string; dark: string };
+
   constructor(
     collectionName: string,
     databaseName: string,

src/language/README.md

@@ -8,10 +8,7 @@
 
 The language server protocol [(LSP)](https://microsoft.github.io/language-server-protocol/specification) is mainly used as a tool between the editor (the client) and a language smartness provider (the server) to integrate features like autocomplete, go to definition, find all references, list document symbols, signature help and much more. You can find the complete list of supported features in [the official documentation](https://code.visualstudio.com/api/language-extensions/language-server-extension-guide).
 
-We can also extend the mongodb language server and client with custom methods to leverage it as a background worker. Because the language server is a separate JSON RPC enabled process, we can add RPC definitions for:
-
-- Execute playground .mongodb scripts with mongosh repl evaluator thingie
-- Schema analysis and caching
+We extend the mongodb language server and client with custom methods to leverage it as a background worker.
 
 ### Debugging
 

src/language/languageServerController.ts

@@ -116,10 +116,6 @@ export default class LanguageServerController {
   }
 
   deactivate(): void {
-    if (!this._client) {
-      return undefined;
-    }
-
     // Stop the language server
     void this._client.stop();
   }

src/mdbExtensionController.ts

@@ -196,9 +196,6 @@ export default class MDBExtensionController implements vscode.Disposable {
       EXTENSION_COMMANDS.MDB_RUN_ALL_OR_SELECTED_PLAYGROUND_BLOCKS,
       () => this._playgroundController.runAllOrSelectedPlaygroundBlocks()
     );
-    this.registerCommand(EXTENSION_COMMANDS.MDB_REFRESH_PLAYGROUNDS, () =>
-      this._playgroundsExplorer.refresh()
-    );
 
     // ------ EXPORT TO LANGUAGE ------ //
     this.registerCommand(EXTENSION_COMMANDS.MDB_EXPORT_TO_PYTHON, () =>
@@ -546,11 +543,7 @@ export default class MDBExtensionController implements vscode.Disposable {
       }
     );
     this.registerCommand(
-      EXTENSION_COMMANDS.MDB_CREATE_PLAYGROUND_FROM_VIEW_ACTION,
-      () => this._playgroundController.createPlayground()
-    );
-    this.registerCommand(
-      EXTENSION_COMMANDS.MDB_CREATE_PLAYGROUND_FROM_PLAYGROUND_EXPLORER,
+      EXTENSION_COMMANDS.MDB_CREATE_PLAYGROUND_FROM_TREE_VIEW,
       () => this._playgroundController.createPlayground()
     );
     this.registerCommand(