Skip to content

Conversation

mmarcon
Copy link
Member

@mmarcon mmarcon commented Apr 14, 2020

appname was being set only when connecting to a new connection but not when connecting to one that was already added. This fixes it.

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mmarcon mmarcon requested a review from Anemy April 14, 2020 12:58
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for catching, moved the setting into the connect just to make sure it always adds it. Once tests pass I can merge

@mmarcon
Copy link
Member Author

mmarcon commented Apr 14, 2020

Ah, yeah, makes sense to move it there.

@Anemy Anemy merged commit b5c6345 into master Apr 14, 2020
@Anemy Anemy deleted the appname-client-meta branch April 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants