Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Apr 16, 2020

https://jira.mongodb.org/browse/VSCODE-85

This PR adds a button to the tree view for when the user has not yet added a connection. This should improve the experience for users who have just installed the extension.

Note: If the user adds a connection and removes it, the button does not show up. If they refresh their vscode though, and there are no connections, it will show up. When they're first loading the extension and their connections have not yet loaded, the message also shows up - which might be enough of a reason not to use this button format. From what I've read it looks like there's no way for us to specify that our extension is being activated... microsoft/vscode#59645 This will be less of an issue once we're webpacking and load times are hopefully significantly reduced.

Screenshots


Screen Shot 2020-04-16 at 7 11 41 PM

Apr-16-2020 18-06-38

@Anemy Anemy requested a review from alenakhineika April 16, 2020 17:12
@Anemy Anemy changed the title VSCODE-75: Add connect form ssh methods VSCODE-85: Add default button to tree view Apr 16, 2020
@Anemy
Copy link
Member Author

Anemy commented Apr 17, 2020

Added create playground as a dropdown button:
Screen Shot 2020-04-17 at 5 44 24 PM

And changed the connect button behavior to opening the connect form instead of connection string input.

Copy link
Contributor

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to have create a playground in the same list with connection items in the contextual menu? It looks confusing like you have a third option to connect using a playground. But is is kind of opposite. You can't use a playground if you are not connected.

@Anemy
Copy link
Member Author

Anemy commented Apr 20, 2020

@alenakhineika I think it's useful to have access to it in the UI - right now it's a bit tough to discover just through the command palette. I think this is probably more of a temporary solution until we have a proper playground tree view: https://jira.mongodb.org/browse/VSCODE-86

@Anemy Anemy force-pushed the VSCODE-85/Add-default-connect-button branch from f8883cc to db0ff18 Compare April 20, 2020 14:44
@Anemy Anemy merged commit b5ed64c into master Apr 20, 2020
@Anemy Anemy deleted the VSCODE-85/Add-default-connect-button branch April 20, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants